Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new subheader prop and custom class names on ListingCard #1880

Merged
merged 2 commits into from
Sep 28, 2021
Merged

feat: new subheader prop and custom class names on ListingCard #1880

merged 2 commits into from
Sep 28, 2021

Conversation

emilyjablonski
Copy link
Collaborator

Pull Request Template

Issue

Addresses #1879

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Allows for new optional subheader prop on ListingCard as well as optional classnames to style both headers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

New Storybook story

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@emilyjablonski
feat: new subheader prop and custom class names on ListingCard
e2ddbc7 
Subheader optionally appears above the unit summary table

BREAKING CHANGE: tableHeader prop moved into a new tableHeaderProps object that contains all the new
header props
@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited
Loading

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 14c69fa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/614e2558f51f69000712e1ad

😎 Browse the preview: https://deploy-preview-1880--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited
Loading

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 14c69fa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/614e25587addad0008454101

😎 Browse the preview: https://deploy-preview-1880--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited
Loading

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 14c69fa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/614e2558906f6f0008513791

😎 Browse the preview: https://deploy-preview-1880--dev-storybook-bloom.netlify.app

@emilyjablonski emilyjablonski linked an issue Sep 24, 2021 that may be closed by this pull request
Allow subheader for unit summary table #1879
Closed
@emilyjablonski emilyjablonski added ready for review sf request Changes requested by the DAHLIA team labels Sep 24, 2021
jaredcwhite
jaredcwhite approved these changes Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing, no biggie—the image doesn't appear to be loading on the Storybook example: https://deploy-preview-1880--dev-storybook-bloom.netlify.app/?path=/story/listing-listingcard--basic-card

@emilyjablonski
Copy link
Collaborator Author

Thank you! Intentional so you could see the aria but maybe that was a bad move

@emilyjablonski emilyjablonski merged commit 4147738 into dev Sep 28, 2021
@emilyjablonski emilyjablonski deleted the feat/1879-table-subheader branch September 28, 2021 14:37
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
@emilyjablonski
Merge pull request bloom-housing#1880 from bloom-housing/feat/1879-ta…
6356849 
…ble-subheader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredcwhite jaredcwhite jaredcwhite approved these changes

Assignees
No one assigned
Labels
sf request Changes requested by the DAHLIA team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow subheader for unit summary table
2 participants
@emilyjablonski @jaredcwhite